Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/remove-zkProgrammable #249

Open
wants to merge 38 commits into
base: develop
Choose a base branch
from
Open

feature/remove-zkProgrammable #249

wants to merge 38 commits into from

Conversation

ejMina226
Copy link
Collaborator

@ejMina226 ejMina226 commented Dec 19, 2024 •
edited
Loading

The latest version of o1js includes the ability to mock a zkProgram. This was the original motivation behind the zkProgrammable abstract class and so it can be removed. This PR includes the following:

  1. Upgrade o1js to version 2.
  2. Fix the types that have changed because of this.
  3. Remove zkProgrammable and WithZkProgrammable and use zkProgramFactory and WithZkProgram

@ejMina226 ejMina226 self-assigned this Dec 19, 2024
@ejMina226 ejMina226 linked an issue Dec 19, 2024 that may be closed by this pull request
Remove ZkProgrammable in favor of new ZkProgram #198
Open
@ejMina226 ejMina226 marked this pull request as ready for review January 8, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ejMina226 ejMina226

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ZkProgrammable in favor of new ZkProgram
1 participant
@ejMina226